search

rogierschouten / async-lock

Lock on asynchronous code for Nodejs
MIT License
394 stars 50 forks source link

using `maxOccupationTime` in typescript not working #45

Closed npomfret closed 3 years ago

npomfret commented 3 years ago

Error:(8, 40) TS2345: Argument of type '{ maxOccupationTime: number; }' is not assignable to parameter of type 'AsyncLockOptions'. Object literal may only specify known properties, and 'maxOccupationTime' does not exist in type 'AsyncLockOptions'.

rogierschouten commented 3 years ago

@npomfret thank you for reporting.

@abozaralizadeh and @ThePiz are you willing to fix this? The TypeScript definitions need adjusting.

abozaralizadeh commented 3 years ago

Seems to be an unrelated issue to this package. it seems to be related to DefinitelyTyped that uses async-lock & you've already figured it out here: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/52626

rogierschouten commented 3 years ago

Then I'll close it here, thanks