roipeker / graphx

GraphX package for Flutter.
https://pub.dev/packages/graphx
MIT License
496 stars 49 forks source link

Migrated to null safety and made another branch #13

Closed IsmailAlamKhan closed 3 years ago

MarceloRab commented 3 years ago

My suggestions in graphx_widget.dart - > SceneBuilderWidget

final SceneController Function() builder; ... required this.builder, ...

late SceneController _controller;

...

_controller = widget.builder(); '

MarceloRab commented 3 years ago

Excuse me. I still don't know how to pull.

MarceloRab commented 3 years ago

My suggestions in render.dart - > graphics

final points = List.filled(sides, null); = > final points = List.filled(sides, Offset(0, 0));

NOTICE: This constructor cannot be used in null-safe code. /// Use [List.filled] to create a non-empty list.

IsmailAlamKhan commented 3 years ago

@MarceloRab I fixed what you suggested.

MarceloRab commented 3 years ago

FIx - core > scene_controller

f ((_config.useKeyboard ?? false) || (_config.usePointer ?? false)) {

I don't know why it is generating an error. Would it be something on nullsafety?

IsmailAlamKhan commented 3 years ago

FIx - core > scene_controller

f ((_config.useKeyboard ?? false) || (_config.usePointer ?? false)) {

I don't know why it is generating an error. Would it be something on nullsafety? Can you say what error you are getting?