roipoussiere / cadquery-server

A web server used to render 3d models from CadQuery code loaded dynamically.
MIT License
57 stars 17 forks source link

Doesn't work with python 3.8 or 3.9 - request fix #83

Open glyn-generative opened 1 year ago

glyn-generative commented 1 year ago

Hey,

Really like the functionality this brings and managed to get latest version (0.4.1) installed using poetry, but it seems to fail with python 3.8 or 3.9 because of use of TypeA|TypeB rather than for example Union[TypeA, TypeB] (from Typing package) in various function calls in file ui.py. image

It worked really well with python 3.10 when the | syntax was introduced, but the package claims to work with python 3.8-3.10 so feels worth the 2 mins to fix.

Wondered if it was possible to edit the ui.py file to fix this? I can see it locally in the installed package but can't find it on gitlab, otherwise I'd just have submitted a pull request.

Thanks for all the hard work