Closed balicea closed 2 years ago
@balicea, everything looks good except the Portuguese translation that you added. I cannot understand the sense of adding it if we are not supporting this localization in the application code, i.e. it will not be used?
@mihail-varbanov It could be used eventually, although at this point in the Illinois App more than here. I promised the instructor of this course that I would commit these contributions to the main Safer Illinois repository so the student could see their work in context. See my response to Mark below for more details. This class is using a translation tool called CrowdIn, which will make it easy for them in future courses to add these languages to the Illinois App.
I was not clear on the process for adding a language localization -- is this something an open-source contributor can add, or is this something ideally handled by the development team? If the former, we might add functionality down the road, so having this committed would eventually be useful for educational purposes (even through Safer is being deprecated).
@pmarkhennessy, why are we doing this to a product that most probably will drop very soon?
@pmarkhennessy We started this project before it was determined that Safer Illinois would be dropped. I made a promise to the instructor of the course I am working with to commit these translations to the main Safer Illinois repository. Ideally, she would like to see them tested in a testing environment, but that does not need to be done immediately. The next time they do this course, the students will be translating strings in the Illinois App.
Description
Please provide a summary of the pull request and the issue it fixes. Please add necessary details, context, dependencies, explanation of when review is needed (see next section), etc.
Fixes #(add issue number here and remove parentheses)
Review Time Estimate
Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.
Type of changes
Please select a relevant option:
Checklist:
Please select all applicable options: