Revisions of Translations of Text Strings (previously PR #760)

[balicea]

Description

Please provide a summary of the pull request and the issue it fixes. Please add necessary details, context, dependencies, explanation of when review is needed (see next section), etc.

Fixes #(add issue number here and remove parentheses)

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

• [ ] Immediately
• [ ] Within a week
• [ x ] When possible

Type of changes

Please select a relevant option:

• [ ] Bug fix (non-breaking change which fixes an issue).
• [ ] New feature (non-breaking change which adds functionality).
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
• [ x ] Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

• [ x ] I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
• [ ] I have updated the CHANGELOG.
• [ x ] I have read the Contributor Guidelines.
• [ x ] I have performed a self-review of my own code.
• [ ] I have commented my code, particularly in hard-to-understand areas.
• [ ] My change requires updating the documentation.
• [ ] I have made necessary changes to the documentation.
• [ ] I have added tests related to my changes.
• [ ] My changes generate no new warnings.
• [ ] New and existing unit tests pass locally with my changes.
• [ ] Any dependent changes have been merged and published in downstream modules.

---

[balicea]

@balicea, everything looks good except the Portuguese translation that you added. I cannot understand the sense of adding it if we are not supporting this localization in the application code, i.e. it will not be used?

@mihail-varbanov It could be used eventually, although at this point in the Illinois App more than here. I promised the instructor of this course that I would commit these contributions to the main Safer Illinois repository so the student could see their work in context. See my response to Mark below for more details. This class is using a translation tool called CrowdIn, which will make it easy for them in future courses to add these languages to the Illinois App.

I was not clear on the process for adding a language localization -- is this something an open-source contributor can add, or is this something ideally handled by the development team? If the former, we might add functionality down the road, so having this committed would eventually be useful for educational purposes (even through Safer is being deprecated).

@pmarkhennessy, why are we doing this to a product that most probably will drop very soon?

@pmarkhennessy We started this project before it was determined that Safer Illinois would be dropped. I made a promise to the instructor of the course I am working with to commit these translations to the main Safer Illinois repository. Ideally, she would like to see them tested in a testing environment, but that does not need to be done immediately. The next time they do this course, the students will be translating strings in the Illinois App.