search

rolandoislas / BrightWebSocket

RFC 6455 WebSocket Library for the Roku
Other
14 stars 11 forks source link

Code questions #6

Open lkrocek opened 5 years ago

lkrocek commented 5 years ago
  1. Not clear to me why is this Client library sending pings on server. This should be part of server or if this lib is able to being as a server as well it should be switch automatically or by configuration, so for me it's doing an extra work which is not required, or was there some reason of this?

https://github.com/rolandoislas/BrightWebSocket/blob/15d9b4bb36ef0741d8743d50b99921520fa7a33e/src/web_socket_client/WebSocketClient.brs#L166

  1. Why it's sending so much? in which frozen land you need to do a ping-pong every 1 second once it's trafficless or should be configurable at least.

https://github.com/rolandoislas/BrightWebSocket/blob/15d9b4bb36ef0741d8743d50b99921520fa7a33e/src/web_socket_client/WebSocketClient.brs#L182

  1. once we know connection is closed why we are waiting 30 seconds to dispatch close event, additionaly should be again in constant somewhere on start of file...

https://github.com/rolandoislas/BrightWebSocket/blob/15d9b4bb36ef0741d8743d50b99921520fa7a33e/src/web_socket_client/WebSocketClient.brs#L174

I could do PR with those changes but, want to be sure what is the reasons.