Support Multiple Line Selection for Comments

RunnersReign commented 12 years ago

When making a comment on a code diff using the Eclipse Plugin, I would normally select multiple lines that I want to make the comment on and then make the comment on that block of text. This is great for instances where you want to show the entire section of code that will cause the error. I finding however that the the comment only refers to the first line of the selection when creating the comment, not the entire highlighted selection.

Steps to Reproduce:

View a review in Eclipse
Select multiple lines to make a comment on.
Right click and select "Add Comment"
Enter in text and click "Ok"
Post comment to server.

If you open the review within the Review Board web application, you can see only the first line selected is shown as having a comment associated with it.

It would be a great if all lines selected would be commented on instead of just the first line.

rombert commented 12 years ago

Thanks for raising this issue. We build on the support from the Mylyn Reviews project, so this might not be implemented upstream. I'll check and see if we can do something locally.

ittaiz commented 10 years ago

Any news? During code review I'd like to comment on a method and not a specific line or the entire commit

rombert commented 10 years ago

No, this still has not been implemented.

On Tue, Mar 25, 2014 at 10:00 AM, Ittai Zeidman notifications@github.comwrote:

Any news? During code review I'd like to comment on a method and not a specific line or the entire commit

— Reply to this email directly or view it on GitHubhttps://github.com/rombert/ereviewboard/issues/92#issuecomment-38538660 .

http://robert.muntea.nu/