Revising balances and amounts fetching. Forex issues. - Githubissues

ronaldlam / Autotrageur

Automated arbitrageur

2 stars 1 forks source link

Revising balances and amounts fetching. Forex issues. #164

Closed jaonewguy closed 6 years ago

jaonewguy commented 6 years ago

Combined PR with Ron and Drew for bug surrounding insufficient quote KRW amount of Bithumb to perform trades.

PR includes:

Using quote_bal instead of usd_bal when preparing the trade now
rid of usd_bal in favor of always fetching a usd_balance when required (to ensure that it is using the most up to date forex rate)
correcting affected tests
changing sandbox and dryrun config wallet amounts to better reflect at least $20k USD of base/quote assets on each exchange

Still needed:

tests for new functions