search

ronancpl / HeavenMS

An improved server based on MapleSolaxia (v83 MapleStory private server)
GNU Affero General Public License v3.0
1.03k stars 742 forks source link

Weapon attack bypass with Puppet #446

Closed BHB88 closed 5 years ago

BHB88 commented 5 years ago

Bowmasters are able to bypass weapon attack when bosses are targeting the Puppet.

0db93e5936e742d3e42140a0fadfb6d2

Ran a test with @bosshp before and during weapon attack on 3 occasions to confirm it isn't a visual bug.

ronancpl commented 5 years ago

Not so sure on how this is supposed to be an issue, neither why it would be related to Puppet at all. What kind of exploit do you mean by bypassing weapon attack? Players would be able to rack more damage to the boss than they are supposed to do?

BHB88 commented 5 years ago

Oh, I meant cancel weapon attack.

BM/MM can attack through cancel weapon attack on bosses if they cast puppet.

CanIGetaPR commented 5 years ago

Is the cancel weapon attack icon still visible? This might be a client bug, and just show the server doesn't enforce the cancel weapon attack in general.

I couldn't find any checks to see if a monster has WEAPON_IMMUNITY status so that means the server doesn't enforce this and anyone can hack the game and ignore it.

ronancpl commented 5 years ago

You're right, indeed there's lacking a check for immunity statuses. Thanks for pointing this out!

BHB88 commented 5 years ago

The icon is indeed still visible in the scenario described above. The bowmaster is able to attack through cancel weapon attack but his party cannot. Although I did notice in other cases, the icon completely disappears thus allowing everyone to attack.

ronancpl commented 5 years ago

Immunity checks have been applied now. Thanks for reporting!