search

ronancpl / HeavenMS

An improved server based on MapleSolaxia (v83 MapleStory private server)
GNU Affero General Public License v3.0
1.03k stars 742 forks source link

Deadlocks #475

Closed davidlafriniere closed 5 years ago

davidlafriniere commented 5 years ago

I've attempted to track down and fix the problem myself. The first set of deadlocks seem to have something to do with buffs? I was testing with another player and it seems my GM buffs, wore off as he was transitioning through a portal and it caused a deadlock.

The second deadlock occurred again when he was entering a portal.

Each file is labeled with a date to distinguish the occurrences. Locks_05282019.txt Locks_06032019.txt Path_05282019.txt Path_06032019.txt

jongames commented 5 years ago

I recently noticed this too. @buffme has not caused this for me BUT @empowerme command causes this behavior. It always occurs with using @empowerme followed by !goto (any town). !warpto (playername) also results in this issue.

It also sometimes occurred with boss map portals / event maps for me so far.

ronancpl commented 5 years ago

Noticed a deadlock pattern in those logs:

----------------------------
28-05-2019 07:08:34
    CHARACTER_EFF CHARACTER_CHR 

----------------------------
28-05-2019 07:08:34
    PORTAL CHARACTER_CHR CHARACTER_CHR CHARACTER_EFF

Both try to access locks in a different order, causing deadlock.

ronancpl commented 5 years ago

This deadlock case has now been cleared. There was a deadlock issue within the recently implemented updateBuffEffects. Thanks for reporting!