Script engine refactor preparation

ronancpl / HeavenMS

An improved server based on MapleSolaxia (v83 MapleStory private server)

GNU Affero General Public License v3.0

1.03k stars 742 forks source link

Closed kolakcc closed 5 years ago

kolakcc commented 5 years ago

In order to make it easier to work with scripting, we need to clean up the base class:

Remove references to Invocable. We require that we find a NashornScriptEngine (as finding another ScriptEngine is catastophic anyways). Since NashornScriptEngine is an Invocable, we don't need these extra casts.
Remove potentially dangerous cache of engine.

kolakcc commented 5 years ago

Fixed NPE by extracting cache mechanism in client away from retrieving a script.

BHB88 commented 5 years ago

Scripts aren't loading at all after the NPE fix