room-15 / ChatSE

An Android application for StackOverflow and StackExchange chat! Revived by Tristan Wiley, base app created by Anubian
Apache License 2.0
22 stars 18 forks source link

Replace ProgressDialog with non-deprecated alternative #50

Closed TristanWiley closed 5 years ago

TristanWiley commented 6 years ago

Same behavior, we just want to change ProgressDialog to something else since it's deprecated.

In LoginActivity.kt

Mauker1 commented 6 years ago

We could go back to MaterialDialog, since it’ll keep the same look across all android versions.

Em qua, 15 de nov de 2017 às 00:33, Tristan Wiley notifications@github.com escreveu:

Same behavior, we just want to change ProgressDialog to something else since it's deprecated.

In LoginActivity.kt

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/room-15/ChatSE/issues/50, or mute the thread https://github.com/notifications/unsubscribe-auth/ACoBKGjZAyi6-ReqrZymrOHQ7Opr2DeGks5s2ludgaJpZM4QeWET .

-- Maurício Pessoa

TristanWiley commented 6 years ago

We could also just use a ProgressBar

raghunandankavi2010 commented 5 years ago

How about adding a progressbar around the fab https://github.com/JorgeCastilloPrz/FABProgressCircle?. Let me know your thoughts on this to remove the deprecated progress dialog!.

Mauker1 commented 5 years ago

I think I'd rather just use a progressbar or something, that way we can avoid adding yet another dependency, and we won't block the UI.

raghunandankavi2010 commented 5 years ago

ok.