Provide default fabricApiKey

room-15 / ChatSE

An Android application for StackOverflow and StackExchange chat! Revived by Tristan Wiley, base app created by Anubian

Apache License 2.0

22 stars 18 forks source link

Provide default fabricApiKey #96

Closed TimCastelijns closed 5 years ago

TimCastelijns commented 5 years ago

Remove the fabricApiKey set up instructions and a) hardcode it into the app, or b) host it somewhere and have a gradle task download it during building.

It's not a problem to make this key public

Nobody cares about it. Fabric is free to use
People can easily decompile the apk and grab it from there anyway if they want to steal it

The gain here is that we remove a set up step.

In case this is really unwanted, we can still provide the 000 key by default, just dump it in the buildconfig during building. Still saves a set up step.

Mauker1 commented 5 years ago

We could do that. But I believe it's better if I create a new key and project for this.

Also, I'll need the contributor emails to register on ChatSE's project.

TimCastelijns commented 5 years ago

What would be the purpose of the 2nd project?

Mauker1 commented 5 years ago

I belive I used the wrong word for it. Group seems to be the correct term for it.

Right now it's using the api key from a personal group. So I'll create one for this app, and we can post the new api key.

Mauker1 commented 5 years ago

I created the "ChatSE" organization on Fabric, and generated a new key. I'll push it later on.

TimCastelijns commented 5 years ago

@Mauker1 should the docs be updated?