Closed jrafidi closed 10 years ago
It appears that this doesn't remember pane positions. That is, if you open a pane and move it, its position is reset when you refresh.
Yea, there is no sense of scroll, but it saves your selected message.
Having it remember scroll position is going to be a bit tougher, primarily because on each scroll, you'd have to pick a message on screen and store its ID and scroll position. Then on reload, you'll have to use that as reference, or the selected message if there is one.
Will try to do at some point this week, or someone else can look into it. On Jun 10, 2014 10:32 AM, "Justin Dove" notifications@github.com wrote:
It appears that this doesn't remember pane positions. That is, if you open a pane and move it, its position is reset when you refresh.
— Reply to this email directly or view it on GitHub https://github.com/roost-im/roost-client/issues/59#issuecomment-45645882 .
Oh, right, there's that too. That's not what I mean.
What I'm saying is that if you move a pane with [shift]-left/right, the new position isn't remembered.
OH. Okay. That's much easier. Thanks for reporting it.
Should be fixed in a870adab59a5616a60bce8bdb8a8f004b5c237b1
Is the current amount of state saving satisfactory? That is: number of panes, pane filters, pane order, and selected message in each pane if there is one.
The only thing I think I'd add is selected pane. I always find it odd when I start up Roost mobile and am alllll the way over at my rightmost pane, which is my least used pane.
Fixed in 5e2b331b79dcad1e986ba5719c0dc5ee40b48f67, but scroll positions remain.
We should save the state of the application between refreshes/across devices. By state I mean: