search

ros-controls / control_msgs

contains base messages and actions useful for controlling robots
https://control.ros.org
BSD 3-Clause "New" or "Revised" License
49 stars 65 forks source link

Recommended copyright notice for control_msgs #120

Open evan-flynn-apexai opened 7 months ago

evan-flynn-apexai commented 7 months ago

Would it be possible to add / recommend a copyright notice for this package?

Usually most packages in ROS 2 utilize ament_copyright to automate this chore a bit, but you dont necessarily have to use it if you dont want.

christophfroehlich commented 7 months ago

What is missing in your opinion? ament_copyright only complains about a missing CONTRIBUTING.md file

evan-flynn-apexai commented 7 months ago

@christophfroehlich so one of the clauses of the license is to "retain the above copyright notice"....so usually with BSD-3 clause license files there is a copyright notice at the top stating who owns the copyrights to the software.

Usually it looks something like Copyright 2024 Christoph Froehlich or something similiar

evan-flynn-apexai commented 7 months ago

My bad about recommending ament_copyright...I thought it would catch it and fix it automatically for you :sweat_smile: but i guess it doesnt

christophfroehlich commented 7 months ago

but this repo only hosts message definitions, and I never saw copyright notices in *.msg files?!

evan-flynn-apexai commented 7 months ago

but this repo only hosts message definitions, and I never saw copyright notices in *.msg files?!

@christophfroehlich here I am not talking about the .msg files, I am talking about the LICENSE file itself. The BSD-3 license expects / requires there to be a copyright notice at the top.

christophfroehlich commented 7 months ago

Where do you have this information from? ament_copyright expects exactly that file: https://github.com/ament/ament_lint/blob/rolling/ament_copyright/ament_copyright/template/bsd_3clause_license.txt

evan-flynn-apexai commented 7 months ago

@christophfroehlich it is part of the licnese text of BSD 3. Ill create an issue in ament_copyright though about this topic, it should be updated there as well.

evan-flynn-apexai commented 7 months ago

spun out the issue in ament_copyright: https://github.com/ament/ament_lint/issues/483

@christophfroehlich in the mean time: can you just advise us on what should the copyright notice be for this package?

christophfroehlich commented 7 months ago

Recently we used something like Copyright 2024 ros2_control Development Team