search

ros-controls / gazebo_ros2_control

Wrappers, tools and additional API's for using ros2_control with Gazebo Classic
Apache License 2.0
188 stars 120 forks source link

Passive joints are broken #219

Closed christophfroehlich closed 9 months ago

christophfroehlich commented 11 months ago

As a consequence of #177 , passive joints don't work any more (try #172).

The joint is now fixed, even if no command interface is defined.

christophfroehlich commented 11 months ago

@AndyZe is this fallback which you introduced really needed? https://github.com/ros-controls/gazebo_ros2_control/blob/6458276ca1eaf3ee646afa8e0833386f9785e585/gazebo_ros2_control/src/gazebo_system.cpp#L612-L613

Deleting it fixes passive joints again, see c043d8007e87eeac910048b7fd24598355cbf0c1

bmagyar commented 11 months ago

That PR was fairly old I think when we merged it, it's not too surprising something wasn't fully aligned.

bmagyar commented 11 months ago

I'll make myself a reminder note to never merge wildly unscoped PRs in the future ;)

christophfroehlich commented 9 months ago

fixed with #237