search

ros-controls / gazebo_ros2_control

Wrappers, tools and additional API's for using ros2_control with Gazebo Classic
Apache License 2.0
188 stars 120 forks source link

Activate CI for humble #223

Closed christophfroehlich closed 9 months ago

christophfroehlich commented 11 months ago

CI is not activated for branches other than master:

Gazebo ros2 control CI

I don't think this is on purpose?

ahcorde commented 11 months ago

we have different branches for each one of the ROS version, this might fail because of the different ros_control APIs

christophfroehlich commented 11 months ago

I'm aware of the branches, but the workflow file in the humble branch doesn't run on pushs on humble: https://github.com/ros-controls/gazebo_ros2_control/blob/8ce87338b8fae820f0877ec68532b47d72fed005/.github/workflows/ci.yaml#L6

maybe the workflow file doesn't have to be updated on the master branch, but it works if they get updated on both as far as I know.

christophfroehlich commented 11 months ago

I made this PR because humble has no status in the table of the readme image

christophfroehlich commented 9 months ago

apparently, it still doesn't work with the change on the master branch. Can we try a backport of this change to humble?

ahcorde commented 9 months ago

https://github.com/Mergifyio backport humble

mergify[bot] commented 9 months ago

backport humble

✅ Backports have been created

* [#239 Activate CI for humble (backport #223)](https://github.com/ros-controls/gazebo_ros2_control/pull/239) has been created for branch `humble`
christophfroehlich commented 9 months ago

now it's green, thanks ;) image