search

ros-controls / gazebo_ros2_control

Wrappers, tools and additional API's for using ros2_control with Gazebo Classic
Apache License 2.0
186 stars 118 forks source link

Fix crashing due to an invalid parameter in the initial value. #271

Closed Wiktor-99 closed 4 months ago

Wiktor-99 commented 5 months ago

Fix crashes caused by the wrong initial value in the state interfaces. This could be particularly problematic if someone passes 'pi' in xacro instead of '${pi}'. Xacro will evaluate '${pi}' to '3.14', while 'pi' will be evaluated as is ('pi' -> 'pi'), leading to chrash.

Wiktor-99 commented 4 months ago

@bmagyar As pipeline is fixed I assume that failed action cloud be trigger again.

ahcorde commented 4 months ago

https://github.com/Mergifyio backport humble iron

mergify[bot] commented 4 months ago

backport humble iron

✅ Backports have been created

* [#282 Fix crashing due to an invalid parameter in the initial value. (backport #271)](https://github.com/ros-controls/gazebo_ros2_control/pull/282) has been created for branch `humble` but encountered conflicts * [#283 Fix crashing due to an invalid parameter in the initial value. (backport #271)](https://github.com/ros-controls/gazebo_ros2_control/pull/283) has been created for branch `iron` but encountered conflicts