search

ros-controls / gazebo_ros2_control

Wrappers, tools and additional API's for using ros2_control with Gazebo Classic
Apache License 2.0
186 stars 118 forks source link

Initialize antiwindup variable properly #326

Closed christophfroehlich closed 1 month ago

christophfroehlich commented 1 month ago 
/workspaces/ros2_baustelle_ws/src/ros-controls/gazebo_ros2_control/gazebo_ros2_control/src/gazebo_system.cpp: In member function ‘control_toolbox::Pid gazebo_ros2_control::GazeboSystem::extractPID(std::string, hardware_interface::ComponentInfo)’:
/workspaces/ros2_baustelle_ws/src/ros-controls/gazebo_ros2_control/gazebo_ros2_control/src/gazebo_system.cpp:231:93: warning: ‘antiwindup’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  231 |   return control_toolbox::Pid(kp, ki, kd, max_integral_error, min_integral_error, antiwindup);
      |                                                                                             ^
christophfroehlich commented 1 month ago

@mergifyio backport humble iron

mergify[bot] commented 1 month ago

backport humble iron

✅ Backports have been created

* [#327 Initialize antiwindup variable properly (backport #326)](https://github.com/ros-controls/gazebo_ros2_control/pull/327) has been created for branch `humble` * [#328 Initialize antiwindup variable properly (backport #326)](https://github.com/ros-controls/gazebo_ros2_control/pull/328) has been created for branch `iron`