search

ros-drivers / flir_camera_driver

163 stars 154 forks source link

Include noetic build in CI #67

Open stwirth opened 3 years ago

stwirth commented 3 years ago
stwirth commented 3 years ago

Seems the CI doesn't like

#!/usr/bin/env python

Maybe the script should be ported to python3? Should still work fine for kinetic/xenial.

stwirth commented 3 years ago

Clearpath seems to host the 2.2.0.48 version of the Spinnaker SDK on https://packages.clearpathrobotics.com/stable/flir/Spinnaker/Ubuntu20.04/. The download_spinnaker script would need to be adapted to pull from there. The version specified there (1.27.0.48) does not seem to be published by FLIR for Ubuntu 20.04.

stwirth commented 3 years ago

Still a little more work needed to match download_spinnaker and DownloadSpinnaker.cmake.

stwirth commented 3 years ago

Last noetic build went through but kinetic and melodic failed with:

make[2]: *** No rule to make target 'spinnaker-sdk/usr/lib/libSpinnaker.so', needed by '/root/target_ws/devel/.private/spinnaker_camera_driver/lib/libSpinnakerCameraLib.so'.  Stop.

Took me almost a day to find out that this is caused by a broken symbolic link in the spinnaker debians version 1.27.0.48. :exploding_head:

stwirth commented 3 years ago

@mhosmar-cpr this is ready for review.

stwirth commented 3 years ago

@mhosmar-cpr ping

Jaeyoung-Lim commented 3 years ago

@stwirth @mhosmar-cpr Any reason that this is not getting in?

stwirth commented 3 years ago

@stwirth @mhosmar-cpr Any reason that this is not getting in?

Not from my side, this is waiting for comment/merge from a maintainer.