ros-drivers / openni2_launch

Launch files to open an OpenNI2 device and load all nodelets to convert raw depth/RGB/IR streams to depth images, disparity images, and (registered) point clouds.
8 stars 33 forks source link

openni #14

Closed paulbovbel closed 10 years ago

paulbovbel commented 10 years ago

Commit 8abbb3ae7f0e7752eb0d2be6da9aa20b06423efe breaks remote launching functionality for openni2 stack, specifically:

In my top level launch file, I declare machine definitions for two machines: 'robot' and 'remote'.

I want to do top level launch from remote machine, but have them run by default on robot, so declare the machine 'robot' as default, and assign specific nodes to machine 'remote'.

openni2 launch overrides this setting, running the camera nodes on the machine that calls the top level launch file.

Is there any reason why the localhost arg is passed down all the way to the rgbd_launch manager? Wouldn't everything run on localhost by default anyways, unless overridden by the user?

paulbovbel commented 10 years ago

Associated commit https://github.com/ros-drivers/rgbd_launch/commit/30f52a28d1651c3e8a37b32ba218d0cb64242e4b

paulbovbel commented 10 years ago

I suppose this is the only way to launch multiple openni2's on multiple machines simultaneously.