Add tf_prefix same as openni

ros-drivers / openni2_launch

Launch files to open an OpenNI2 device and load all nodelets to convert raw depth/RGB/IR streams to depth images, disparity images, and (registered) point clouds.

8 stars 33 forks source link

Add tf_prefix same as openni #16

Closed markpitchless closed 10 years ago

markpitchless commented 10 years ago

Hi,

The launch seems to be missing the tf_prefix option compared with openni, which is still supported by the rgbd_launch code. Patch adds it.

Was it removed on purpose? Adding this back lets me switch between openni_launch and openni2_launch without having to modify anything or come with new tf naming.

Cheers, mark

mikeferguson commented 10 years ago

It doesn't look like this was ever in the openni2_launch package (AFAIK, this was created from scratch initially, not copied from openni_launch).

LGTM -- I'll wait a day before merging in case any other users seen any issues with it and speak up.

markpitchless commented 10 years ago

I think I just assumed that it was created from openi_launch as it looks pretty similar and supports the same options. Thanks for the quick response.

markpitchless commented 10 years ago

Thanks for the merge @mikeferguson :+1: