search

ros-drivers / openni2_launch

Launch files to open an OpenNI2 device and load all nodelets to convert raw depth/RGB/IR streams to depth images, disparity images, and (registered) point clouds.
8 stars 33 forks source link

machine arg removed from rgbd_launch for Indigo #17

Closed piyushk closed 10 years ago

piyushk commented 10 years ago

As per discussion in https://github.com/ros-drivers/rgbd_launch/issues/5, the machine arg has been removed from rgbd_launch for the upcoming Indigo release.

Machine tags have a scoped default attribute that should be used instead of setting a machine argument for every launch file individually. This way you can still launch a bunch of nodes on multiple remote machines quite easily:

<group>
  <machine name="foo" ... default="true" />

  <!-- all launch files get launch on machine foo -->

</group>
<group>
  <machine name="bar" ... default="true" />

  <!-- all launch files get launch on machine bar -->

</group>

I'll submit a PR with this issue report as well, but an issue report will have to be made with any upstream packages using openni_launch2.

piyushk commented 10 years ago

You'll have to create an indigo-devel for this change. Sorry!

mikeferguson commented 10 years ago

@piyushk Branch is now there. There are no released packages depending on openni_launch2, so it's impossible to know who depends on it -- I know we depend on it, but don't use the machine tag, so this won't affect the UBR-1 packages.

piyushk commented 10 years ago

@mikeferguson That sounds fine. I doubt many people are using the machine tag, and we are only modifying this for the Indigo release.