search

ros-drivers / openni2_launch

Launch files to open an OpenNI2 device and load all nodelets to convert raw depth/RGB/IR streams to depth images, disparity images, and (registered) point clouds.
8 stars 33 forks source link

Release into ROS Lunar #35

Closed 130s closed 6 years ago

130s commented 7 years ago

All dependency seems to be met.

I'm willing to co-maintain this package. Looks like I'm in @ros-drivers/openni team but doesn't seem to have write access here (I do seem to have one at https://github.com/ros-gbp/openni2_launch). Can @mikaelarguedas or any admins take care of this?

mikaelarguedas commented 7 years ago

@130s I can give you access. Did you contact @mikeferguson regarding the co-maintainership? It would be great to update the package.xml so that you receive emails form the buildfarm in case of failing jobs.

@mikeferguson should this manifest be updated to use a more recent email address or is this one still valid ? https://github.com/ros-drivers/openni2_launch/blob/fb8f1ab89a6eb29fdfb9f0026b631bc54283785f/package.xml#L7

130s commented 7 years ago

It would be great to update the package.xml so that you receive emails form the buildfarm in case of failing jobs.

I've actually done that in a PR :) https://github.com/ros-drivers/openni2_launch/pull/29

mikaelarguedas commented 7 years ago

Adding maintainers in unrelated PRs and ask for write access on unrelated issues doesn't have much visibility and has a lower chance to be noticed by maintainers or the community. A better way to ask for co-maintaining a repository / package is to open a dedicated issue and ping the current maintainer(s) on it. Hence I encourage you to open an issue on this repo to that end.

130s commented 7 years ago

https://github.com/ros-drivers/openni2_launch/issues/35#issuecomment-324759274 should be addressed.

Lunar release is done https://github.com/ros-drivers/openni2_camera/issues/49 for openni2_camera, which doesn't provide launch files and thus is less useful with the absence of this package. Hope we can move forward before the next public sync.

130s commented 7 years ago

@mikaelarguedas wrote at https://github.com/ros-drivers/openni2_launch/pull/36#issuecomment-333225541:

As a side question, you mentioned you have access to the release repository of this package. Is there anything preventing from releasing the current kinetic version of openni2_launch into Lunar ?

There seems to be (only but) one change since the last release, so I thought making a new version would still make sense. In order to make a new version I need a write privilege, so #36 :)

130s commented 6 years ago

https://github.com/ros/rosdistro/pull/16054