search

ros-drivers / openni2_launch

Launch files to open an OpenNI2 device and load all nodelets to convert raw depth/RGB/IR streams to depth images, disparity images, and (registered) point clouds.
8 stars 33 forks source link

Add a maintainer #36

Closed 130s closed 6 years ago

130s commented 6 years ago

https://github.com/ros-drivers/openni2_launch/issues/35#issuecomment-324759274 by @mikaelarguedas

Adding maintainers in unrelated PRs and ask for write access on unrelated issues doesn't have much visibility and has a lower chance to be noticed by maintainers or the community. A better way to ask for co-maintaining a repository / package is to open a dedicated issue and ping the current maintainer(s) on it. Hence I encourage you to open an issue on this repo to that end.

Fair enough. So here this is.

@mikeferguson

mikaelarguedas commented 6 years ago

@mikeferguson are you ok with @130s being a co-maintainer of this package (knowing that he already has write access to openni2_camera where he could be listed as a maintainer as well)

130s commented 6 years ago

It's been a month since my request above. I also tried to reach out to Mike but no luck. Could we move forward with this?

mikaelarguedas commented 6 years ago

Yeah I tried to reach out to @mikeferguson too without success, I sent a follow-up email today. If we don;t get any response by next week I'll move forward and grant you access.

As a side question, you mentioned you have access to the release repository of this package. Is there anything preventing from releasing the current kinetic version of openni2_launch into Lunar ?

130s commented 6 years ago

@mikaelarguedas I guess it's time to move :)

And I responded to your question in https://github.com/ros-drivers/openni2_launch/issues/35#issuecomment-333269191

mikaelarguedas commented 6 years ago

I guess it's time to move :)

Indeed it is :) @130s I added you as a contributor, please remember to merge this PR before cutting a new release so that you can receive emails in case of failures on the buildfarm. (It would be great to do the same for openni2_camera before releasing a new version as well).

Thanks for contributing and offering to co-maintain these packages!

130s commented 6 years ago

@mikaelarguedas thanks. I'll make a release after merging this PR.