ros-drivers / openni2_launch

Launch files to open an OpenNI2 device and load all nodelets to convert raw depth/RGB/IR streams to depth images, disparity images, and (registered) point clouds.
8 stars 33 forks source link

enables proper namespacing #6

Closed bit-pirate closed 11 years ago

bit-pirate commented 11 years ago

This is similar to https://github.com/ros-drivers/openni_launch/issues/2

Is there a specific reason why this hasn't been adopted for openni2_launch or has this just been missed?

mikeferguson commented 11 years ago

I think this was missed when I moved over to using rgbd_launch. Name should probably be /camera/nodelet_manager, not /camera/camera_nodelet_manager, no?

bit-pirate commented 11 years ago

We kept that as it was before as we didn't see any drawbacks nor benefits. This is the same as it is in openni1_launch.

mikeferguson commented 11 years ago

ok, lgtm then