ros-drivers / openni2_launch

Launch files to open an OpenNI2 device and load all nodelets to convert raw depth/RGB/IR streams to depth images, disparity images, and (registered) point clouds.
8 stars 33 forks source link

parameter depth_registration not available #7

Closed bit-pirate closed 11 years ago

bit-pirate commented 11 years ago

I just switched the default for one of the robots here from openni1 to 2 and I noticed that openni2_launch does not support a parameter for choosing hardware depth registration aka depth_registration.

Is there a specific reason why this is missing? I see that this parameter is available through dynamic reconfigure and it is turned on by default.

mikeferguson commented 11 years ago

The original set of launch files was not very 1-to-1 with older openni or new rgbd_launch. I think this is as simple as exposing the correct parameter from the underlying rgbd_launch files. I don't have time to address this, but a pull request would be accepted for this.

bit-pirate commented 11 years ago

OK, I'll see what I can do.