search

ros-industrial-attic / CAD-to-ROS

GUI tools for ROS setup files starting with URDFs (Unmaintained)
Apache License 2.0
12 stars 9 forks source link

The new button action does not prompt the user to save before clearing. #99

Open Levi-Armstrong opened 8 years ago

Levi-Armstrong commented 8 years ago

If you load a robot and make changes, then click the new button the model is erased. If changes are made it should probably notify the user with the option to save before clearing.

gavanderhoorn commented 8 years ago

Thanks for the report.

Possible approach for a fix: check the urdf_tree_->unsavedChanges variable in void URDFEditor::on_action_New_triggered() and invoke the appropriate 'save before exit' logic if required, instead of unconditionally clearing everything.

AndyZe commented 8 years ago

@gavanderhoorn @phvass Can you assign this one to me please?

AndyZe commented 8 years ago

I just realized this should include checking for changes before "Open," too

AndyZe commented 8 years ago

Making notes to myself: I couldn't build the m1 branch until "sudo apt-get install liboce-ocaf-dev"

AndyZe commented 8 years ago

Changes to some properties aren't being detected anymore.

gavanderhoorn commented 8 years ago

Making notes to myself: I couldn't build the m1 branch until "sudo apt-get install liboce-ocaf-dev"

Yes. That is documented on the wiki, see wiki/Development, and more specifically, the wiki/OCE-packages page.