search

ros-industrial-consortium / packml

ROS packml (https://en.wikipedia.org/wiki/PackML) support package
Apache License 2.0
9 stars 14 forks source link

Can we merge with bohr now ? #21

Open minlingc opened 7 years ago

minlingc commented 7 years ago

@shaun-edwards @AmyMingli @phvass @AustinDeric

Shaun, ready merge this?

Thanks, Min Ling

shaun-edwards commented 7 years ago

Can you open a PR. If it's a large PR, you may want to break it up into logical chunks/packages.

minlingc commented 6 years ago

@AmyMingli can you open a PR to merge to bohr please?

AmyMingli commented 6 years ago

@minlingc @shaun-edwards The pull request for the readme file has been created last October here: https://github.com/ros-industrial-consortium/bohr_devel/pulls . Let me know if there is any misunderstanding..

shaun-edwards commented 6 years ago

@AmyMingli, the MR is for bohr (one appears to be an empty (no changes) MR, the other has conflicts). This is the packml repo. I thouht @minlingc's question was merging bohr into packml. As far as I know, there doesn't exist an MR for that.

minlingc commented 6 years ago

sorry merge packml into bohr. As this is the name selected by one of the sponsors.

AmyMingli commented 6 years ago

@shaun-edwards I just create another PR to bohr repo to update the README file. Can you take a look and merge it if it is ok? @minlingc I don't think I can merge packml into bohr, as I don't have writing access to either bohr or packml repo. And when the merge is done by another Administrator, the README file also need to be updated.