search

ros-industrial-consortium / packml

ROS packml (https://en.wikipedia.org/wiki/PackML) support package
Apache License 2.0
9 stars 14 forks source link

[packml_sm] Clearer dependency. Remove rqt. #25

Closed 130s closed 7 years ago

130s commented 7 years ago

Toward https://github.com/ros-industrial-consortium/packml/issues/23, I'm learning the code. If I understand correctly, packmlsm package seems to be an implementation of packml and the rest in packml repo (i.e. `packml{gui, msgs, ros}`) are ROS and/or rqt binding of it.

If that is correct, it'd be cleaner and easier for maintenance for packml_sm to be ROS/rqt-agnostic. Although with this PR roscpp remains in use, it looks to be relatively easy to remove roscpp as well. If that's possible packml_sm can be ROS-agnostic, more standalone library.

If this is mergeable, should be done so backward to indigo-devel.

shaun-edwards commented 7 years ago

You exactly right on my intent. I envisioned a packml_qt and a packml_boost implementation of packml_sm. The roscpp depedency is should really only be rosconsole. I'm not aware of a good way of extracting ROS logs from a library. I'm open to suggestions though.

No need to worry about indigo-devel. Similar to ROS-I, I'd like to focus on current release improvements. The old versions can remain stable or be updated if someone has a real need.