search

ros-industrial-consortium / packml

ROS packml (https://en.wikipedia.org/wiki/PackML) support package
Apache License 2.0
9 stars 14 forks source link

Add Install Rules to packml_ros/CMakeLists.txt #27

Closed geoffreychiou closed 6 years ago

geoffreychiou commented 6 years ago

Our continuous integration using industrial_ci failed on packml_ros because packml_ros did not have install rules.

@shaun-edwards Please review.

geoffreychiou commented 6 years ago

Hm... the CI is failing but doesn't seem to be related to my change. @130s any thoughts?

130s commented 6 years ago

I'm not sure...this definitely is different from https://github.com/ros-industrial/industrial_ci/issues/254#issuecomment-355261716. @ipa-mdl Could you have a look?

geoffreychiou commented 6 years ago

I noticed that in industrial_core: https://github.com/ros-industrial/industrial_core/blob/kinetic-devel/.travis.yml the kinetic-devel branch builds with

dist: trusty

This one has xenial, could it be a problem with the xenial image?

geoffreychiou commented 6 years ago

Looks like that works @shaun-edwards

130s commented 6 years ago

Glad that you found it @geoffreychiou...That is exactly the same issue as https://github.com/ros-industrial/industrial_ci/issues/254#issuecomment-355261716. I think I was looking at a wrong branch.