ros-industrial-consortium / packml

ROS packml (https://en.wikipedia.org/wiki/PackML) support package
Apache License 2.0
9 stars 14 forks source link

Replace multiple set state method calls with a single set state method call. #42

Open joshuaplusone opened 6 years ago

joshuaplusone commented 6 years ago
virtual bool setStarting(std::function<int()> state_method) = 0;
virtual bool setExecute(std::function<int()> state_method) = 0;
virtual bool setCompleting(std::function<int()> state_method) = 0;
virtual bool setAborting(std::function<int()> state_method) = 0;
virtual bool setClearing(std::function<int()> state_method) = 0;
virtual bool setStopping(std::function<int()> state_method) = 0;
virtual bool setResetting(std::function<int()> state_method) = 0;
virtual bool setSuspending(std::function<int()> state_method) = 0;
virtual bool setUnsuspending(std::function<int()> state_method) = 0;
virtual bool setHolding(std::function<int()> state_method) = 0;
virtual bool setUnholding(std::function<int()> state_method) = 0;

should be replaced with

virtual bool setStateMethod(StatesEnum state, std::function<int()> state_method) = 0;