search

ros-industrial / ros_canopen

CANopen driver framework for ROS (http://wiki.ros.org/ros_canopen)
GNU Lesser General Public License v3.0
342 stars 273 forks source link

move canopen_chain_node service definitions into can_msgs #335

Open jschleicher opened 5 years ago

jschleicher commented 5 years ago

Inside canopen_chain_node there are two service definitions: GetObject.srv and SetObject.srv. To allow other ROS nodes to <depend> on slim packages (instead of depending on canopen_chain_node), it would be cleaner to have all service and message definitions of the meta-package inside can_msgs.

What do you think?

mathias-luedtke commented 5 years ago

These two services are quite specific to canopen_chain_node (and canopen_master). That's why I kept them in the package.

If there is a need for the service definitions only, I would accept a pull request. However, they do not belong in can_msgs, but in a more specialized package (e.g., canopen_msgs).