Closed JWhitleyWork closed 4 years ago
First of all: Thank you very much, that was a lot of work! It will take some time to review..
In general I would like to backport some of it (code layout, hpp, etc.) to melodic as well, otherwise the maintenance is too hard.
The commit history looks a little bit strange..
Since it sat for a while, there were changes that were made to melodic-devel during development. I had to rebase on melodic-devel to pick them up. That's why the commit history is odd.
I had to rebase on melodic-devel to pick them up. That's why the commit history is odd.
It looks like some commits are duplicated now. This needs so get sorted out before the review. I will see if I can find some time to do so.
@JWhitleyAStuff: I actually wanted to create a PR, but Github pushed it directly.
FYI - there are a few tests that are still failing. Hence the "nearly compete" port. I plan to straighten them out today.
Cancelling this PR to try again with cleaner git
history.
Not everything is complete yet but this adds the majority of a port to ROS Dashing.