search

ros-industrial / ros_canopen

CANopen driver framework for ROS (http://wiki.ros.org/ros_canopen)
GNU Lesser General Public License v3.0
336 stars 271 forks source link

Dashing devel #357

Closed JWhitleyWork closed 4 years ago

JWhitleyWork commented 4 years ago

Not everything is complete yet but this adds the majority of a port to ROS Dashing.

mathias-luedtke commented 4 years ago

First of all: Thank you very much, that was a lot of work! It will take some time to review..

In general I would like to backport some of it (code layout, hpp, etc.) to melodic as well, otherwise the maintenance is too hard.

The commit history looks a little bit strange..

JWhitleyWork commented 4 years ago

Since it sat for a while, there were changes that were made to melodic-devel during development. I had to rebase on melodic-devel to pick them up. That's why the commit history is odd.

mathias-luedtke commented 4 years ago

I had to rebase on melodic-devel to pick them up. That's why the commit history is odd.

It looks like some commits are duplicated now. This needs so get sorted out before the review. I will see if I can find some time to do so.

mathias-luedtke commented 4 years ago

@JWhitleyAStuff: I actually wanted to create a PR, but Github pushed it directly.

JWhitleyWork commented 4 years ago

FYI - there are a few tests that are still failing. Hence the "nearly compete" port. I plan to straighten them out today.

JWhitleyWork commented 4 years ago

Cancelling this PR to try again with cleaner git history.