Missing configuration of topic names in socketcan_bridge

ros-industrial / ros_canopen

CANopen driver framework for ROS (http://wiki.ros.org/ros_canopen)

GNU Lesser General Public License v3.0

332 stars 270 forks source link

Missing configuration of topic names in socketcan_bridge #419

Closed DatDucati closed 3 years ago

DatDucati commented 3 years ago

Hello all, I've noticed that the socketcan_to_topic bridge doesn't support setting the name of the topic the data is exposed on. I've already implemented a fix for that, and will create a pull request for the fix.

Reasoning behind that change is that we can guarantee that this node can be fitted into a space, which have a specific naming scheme.

Done:

socketcan_to_topic_node

Still open:

topic_to_socketcan_node