Added optional configuration to specify received_messages topic name.

ros-industrial / ros_canopen

CANopen driver framework for ROS (http://wiki.ros.org/ros_canopen)

GNU Lesser General Public License v3.0

332 stars 270 forks source link

Closed DatDucati closed 3 years ago

DatDucati commented 3 years ago

Would fix #419

gavanderhoorn commented 3 years ago

Wouldn't this be easier with remapping? Using parameter names for topic names is a bit of an anti-pattern.

DatDucati commented 3 years ago

Well, you learn something new every day I guess :) It's up to you if you want to accept this PR, or not, meanwhile I'll try the remap option.

Edit: It works via remap, just like my code does. I'll close this as it's not needed!

mathias-luedtke commented 3 years ago

It's up to you if you want to accept this PR

As @gavanderhoorn already explained: remapping is the preferred way, so there is no need for such a patch.