search

ros-industrial / ros_canopen

CANopen driver framework for ROS (http://wiki.ros.org/ros_canopen)
GNU Lesser General Public License v3.0
328 stars 267 forks source link

Address inconsistent override warning #472

Closed wxmerkt closed 1 year ago

mathias-luedtke commented 1 year ago

Which warning did you get? In CI I cannot see them. Why only those 5 lines? I guess we could fix that in all files..

wxmerkt commented 1 year ago

With clang we get -Winconsistent-missing-overrides. These were the only ones that were triggered. I also added a commit to address the deprecation of filter_chain.h in Noetic while keeping Melodic compatibility. I no longer see any warnings building this repository

wxmerkt commented 1 year ago

@ipa-hsd friendly ping - is this good to merge?

hsd-dev commented 1 year ago

Sorry I think it got lost in my emails.