search

ros-sports / soccer_interfaces

A set of packages which contain common soccer interface files
Apache License 2.0
8 stars 3 forks source link

3d vision msgs #22

Closed ijnek closed 2 years ago

ijnek commented 2 years ago

This PR adds 3d vision msgs, and extracts some vision attributes out to a new msg package called soccer_vision_attribute_msgs.

Diagrams below show how these messages would fit into a 2d and 3d vision system.

soccer_3d_vision_msgs drawio

image

ijnek commented 2 years ago

Thanks @jaagut, impressed with your review skills! I've fixed up everything you've pointed out.

Due to a rebase, the additional commits are a bit hard to see.

ijnek commented 2 years ago

I've also added an overview in the root README.md as you've suggested. Going to merge this in with the one approval, and all conversations being resolved.

ijnek commented 2 years ago

@Mergifyio backport galactic

mergify[bot] commented 2 years ago

backport galactic

✅ Backports have been created

* [#34 3d vision msgs (backport #22)](https://github.com/ros-sports/soccer_interfaces/pull/34) has been created for branch `galactic`