Add RViz Script - Githubissues

ros-sports / soccer_interfaces

A set of packages which contain common soccer interface files

Apache License 2.0

8 stars 3 forks source link

Add RViz Script #38

Closed Flova closed 2 years ago

Flova commented 2 years ago

Adds a script which displays the soccer_vision_3d_msgs as RViz2 markers.

Resolves: #39

Flova commented 2 years ago

I will do a separate Pull Request for the dokumentation.

ijnek commented 2 years ago

@Flova thank you for this! (and sorry for the late reply - i'm visintg family, but should be more active from early June)

I like the work, the visualizations look nice!

We should take this out and put this work into another work, so that we keep this package a repository containing pure ROS2 interface packages.

Since we have ros-sports/soccer_vision_2d_layers for the soccer_vision_2d_msgs, maybe we could have something similar, like ros-sports/soccer_vision_3d_rviz_markers as a new repo. If you agree, I can go ahead and create the repo and you can copy your work across.

jaagut commented 2 years ago

@ijnek Yes, I agree, that this makes more sense in another repo and keep this clean.

ijnek commented 2 years ago

@Flova I saw the other day that you suggested exactly what I said about separating the repo (on Discord), but I failed to respond to that. Since we all agree, I've created ros-sports/soccer_vision_3d_rviz_markers. Would you be able to move your work across there? Thanks.

ijnek commented 2 years ago

@Flova I believe you don't have time to port this across to the new repo, so I'm starting to work on it. I previously had a similar package (although its outdated), and some notable changes in that package comapred to what you propose here is:

I used MarkerArray for Array msgs, instead of Marker
I published different objects on different topics (eg. /visualization/ball, /visualization/goalposts, etc.), rather than different namespaces. I believe this is the only way you can toggle the visualization on and off for each object (ball, goalpost, etc) in RViz.

I also plan on writing some tests. Do you agree with the suggestions?

jaagut commented 2 years ago

I believe, this can now be closed as replaced by ros-sports/soccer_vision_3d_rviz_markers/pull/2