search

ros / catkin

A CMake-based build system that is used to build all packages in ROS.
http://wiki.ros.org/catkin
BSD 3-Clause "New" or "Revised" License
321 stars 280 forks source link

use single quote for cached environment values without old values #1108

Closed furushchev closed 4 years ago

furushchev commented 4 years ago

Closes #1107

By applying this pull request, exported values of environment variables are quoted using single quote sign. For variables for paths with old values, double quote sign is used as before.

dirk-thomas commented 4 years ago

Thanks for the patch.

I changed the logic a bit to what I hope is more readable and expressive. Please double check if this looks fine to you and still works for your use case.

dirk-thomas commented 4 years ago

Cherry-picked to kinetic-devel in 83ca0d275edb85114248ac0c086a40299e1e871f.

furushchev commented 4 years ago

@dirk-thomas Sorry for the delay. I confirmed that it works after pulled your fixes. (single/double quote are properly used)

# <catkin_ws>/build/test_pkg/catkin_generated/setup_cached.sh

...
export ROSCONSOLE_FORMAT='[${severity}] [${time}] [${node}:${logger}]: ${message}'
export ROSLISP_PACKAGE_DIRECTORIES="/home/furushchev/catkin_ws_debug/devel/.private/test_pkg/share/common-lisp:$ROSLISP_PACKAGE_DIRECTORIES"