search

ros / catkin

A CMake-based build system that is used to build all packages in ROS.
http://wiki.ros.org/catkin
BSD 3-Clause "New" or "Revised" License
321 stars 280 forks source link

CATKIN_PACKAGE_LIBEXEC_DESTINATION mentioned in docs is not implemented #1118

Closed rsinnet closed 4 years ago

rsinnet commented 4 years ago

The documentation mentions the CMake variable CATKIN_PACKAGE_LIBEXEC_DESTINATION. https://github.com/ros/catkin/blob/dfc93c72d9799f57442d08c2f6e9fd494bba95c1/doc/user_guide/variables.rst#L53

In addition, we see the following mentions in configure files: https://github.com/ros/catkin/blob/dfc93c72d9799f57442d08c2f6e9fd494bba95c1/cmake/templates/cfg-extras.context.py.in#L19 https://github.com/ros/catkin/blob/dfc93c72d9799f57442d08c2f6e9fd494bba95c1/cmake/templates/env-hook.context.py.in#L19

Looking through the code, we see no mention of such a variable. https://github.com/ros/catkin/blob/dfc93c72d9799f57442d08c2f6e9fd494bba95c1/cmake/catkin_destinations.cmake

Is this a real variable or perhaps something that was envisioned but never implemented?

rsinnet commented 4 years ago

@dirk-thomas I think this is your code?

dirk-thomas commented 4 years ago

That variable is indeed not populated atm.

Would you be willing to create a pull request either removing the variable or filling it with an actual value?