Port hd_monitor to ROS2

limaanto commented 3 months ago

As promised in #319 (though it took quite a while..), here is a ported version of the HD monitor script.

After the discussions of #319, I decided to :

drop the temperature check that was not deemed mandatory and would have required significant work
use a widely available and windows-compatible tool for the usage check, and shutil.disk_usage which comes with all python installs seemed like a good choice
Introduce a new parameter path to configure where the check is ran on. By default this is the home directory but can be changed with a ros param
Use only the local hostname as the device_id

I did not take the time to write the test yet, let me know if this is mandatory for merging (or if there is any other point for that matter)

ct2034 commented 3 months ago

Thanks for your contribution @limaanto :) Please add also a test. But you should be able to adopt https://github.com/ros/diagnostics/blob/ros2/diagnostic_common_diagnostics/test/systemtest/test_ntp_monitor_launchtest.py directly.

limaanto commented 3 months ago

Hi, I rebased the branch on ros2 and implemented a successful launch test (based on the recommended ntp_monitor's) Tell me if I'm missing something :smiley:

limaanto commented 1 month ago

Hi, I included your review remarks, rebased on the latest ros2 and passed black. Cheers :)

ct2034 commented 1 week ago

@limaanto Please rebase branch and fix flake8 errors

limaanto commented 1 week ago

That should be good :+1:

ct2034 commented 6 days ago

@limaanto friendly ping

ct2034 commented 5 days ago