search

ros / diagnostics

Packages related to gathering, viewing, and analyzing diagnostics data from robots.
https://index.ros.org/p/diagnostics/
Other
102 stars 178 forks source link

common_diagnostics cleaned hostname string #405

Open sjusner opened 2 weeks ago

sjusner commented 2 weeks ago

fixes #404. hostname used for node name now only contains alphanumeric and underscore. Did not introduced any new libraries, also avoided python 3.7 specific feature for compatibility.

Timple commented 2 weeks ago

Just curious, for compatibility with what?

There are no active ROS distributions on python versions older than 3.8

sjusner commented 2 weeks ago

Oh, that's true. Somehow I was thinking about the 3.6 requirements of ROS 2. In that case I'll adapt the change, as the readability will be improved.