#10 Add rule for Decimal field format

roskakori / cutplace

validate data stored in CSV, PRN, ODS or Excel files

http://cutplace.readthedocs.org/

GNU Lesser General Public License v3.0

18 stars 20 forks source link

#10 Add rule for Decimal field format #87

Closed heubi95 closed 9 years ago

heubi95 commented 9 years ago

implemented DecimalRange class in the ranges module
implemented related tests in the test_ranges module
modified the constructor of the DecimalFieldFormat class to support the rule parameter and save the created DecimalRange in the valid_range property
modified the validated_value for the DecimalFieldFormat to check if the value is within the valid_range
implemented related tests

coveralls commented 9 years ago

Coverage increased (+0.46%) to 96.83% when pulling 9f054821a0b0d1d5aaae3dcca8a273c8776df831 on heubi95:master into 266c8ece9571d99367be5421ad660c552287fc8f on roskakori:master.

coveralls commented 9 years ago

Coverage increased (+0.32%) to 98.15% when pulling c5a5df38dd3abe764b5afacad6db276b2c11b8ce on heubi95:master into 27a31ab3215dd54fe192f12d4b7b8c8159c9bf76 on roskakori:master.

coveralls commented 9 years ago

Coverage increased (+0.23%) to 98.06% when pulling 0cc0cbbc9cf05e8e955772d02f937f51ec9ff4a7 on heubi95:master into 27a31ab3215dd54fe192f12d4b7b8c8159c9bf76 on roskakori:master.

coveralls commented 9 years ago

Coverage increased (+0.24%) to 98.06% when pulling f51971fb087a3bbafc3551c220372cab30df9934 on heubi95:master into 27a31ab3215dd54fe192f12d4b7b8c8159c9bf76 on roskakori:master.

coveralls commented 9 years ago

Coverage decreased (-0.11%) to 97.88% when pulling 90b5b569852dda30c7046c3e384e75509bd3148e on heubi95:master into c1576197a957af6da0ad6f780e1d4a24c73ad7d2 on roskakori:master.

coveralls commented 9 years ago

Coverage remained the same at 98.05% when pulling 2c04c938747550e58bc96e60d515d3a2ba5c3bc8 on heubi95:master into 08b48abfb273d1bd8ac43765133787504407e9e5 on roskakori:master.

coveralls commented 9 years ago

Coverage remained the same at 98.05% when pulling 2c04c938747550e58bc96e60d515d3a2ba5c3bc8 on heubi95:master into 08b48abfb273d1bd8ac43765133787504407e9e5 on roskakori:master.

roskakori commented 9 years ago

@heubi95: basically looks good. please address the remaining comments (mostly cleanups), perform an upstream merge to resolve the conflicts that currently prevent an automatic merge and push the changes to update this request.

coveralls commented 9 years ago

Coverage decreased (-0.03%) to 98.11% when pulling da9946922ae22abbf52064b91b481ca558ba7308 on heubi95:master into 8515777a8c30e4caaff98574663f3ffaa7f9ec62 on roskakori:master.

coveralls commented 9 years ago

Coverage decreased (-0.03%) to 98.11% when pulling 2fc6f6d95e16953621118b329c4375ac5eb0e570 on heubi95:master into 8515777a8c30e4caaff98574663f3ffaa7f9ec62 on roskakori:master.