#73 Convert CID to SQL statements

roskakori / cutplace

validate data stored in CSV, PRN, ODS or Excel files

http://cutplace.readthedocs.org/

GNU Lesser General Public License v3.0

18 stars 20 forks source link

#73 Convert CID to SQL statements #96

Closed heubi95 closed 9 years ago

heubi95 commented 9 years ago

implemented as_sql_create_inserts function to generate insert statements from a cid and a data file
coverage improvement

coveralls commented 9 years ago

Coverage increased (+0.5%) to 98.397% when pulling 9712b1f89b6a03015ef02f93dbe73e999683ff73 on heubi95:master into e349b12adf8a166b172c3d37948e4fcf5be541e1 on roskakori:master.

roskakori commented 9 years ago

Concerning the second assert in test_can_represent_none_range(): Which parts of the code is this test supposed to cover that are not already covered by the other tests? Adding items after the constructor should not be supported by Range and DecimalRange. Maybe we should make items a property that returns a tuple (that cannot be modified) instead of a list.

roskakori commented 9 years ago

What error messages do we get for:

'1 Tab 2'
'1 x 2'
'1 2'

roskakori commented 9 years ago

@heubi95: Patrick's changes have been merged so you should be able to continue with this.

roskakori commented 9 years ago

Please resubmit as discussed (to avoid messing with broken branches/forks/work copies/whatnot).

coveralls commented 9 years ago

Coverage increased (+0.07%) to 93.35% when pulling 84649d27892e169d91f2230de98b0895f3023e88 on heubi95:master into f1444be325910d150906efe807395b4e9412541d on roskakori:master.