rosshamish / LeagueGraphs

Statistics tracking for League of Legends
5 stars 0 forks source link

Add database addition of teammates #37

Open rosshamish opened 11 years ago

rosshamish commented 11 years ago
rosshamish commented 11 years ago

Should teammates be added to the auto-updater too?

Should enemies be added? Should all players be added?

Choices:

  1. Nobody is added to anything unless they explicitly enter their name on LeagueGraphs
  2. Teammates are added to the database so that their in-game data can be seen on mouseOver of a particular game.
  3. Teammates and enemies are added to the database so that their in-game data can be seen on mouseOver (or onClick) of a game node in the graph, and a full persective of the game can be seen.

Pros/Cons:

Option 1:

Pros:

Cons:

Option 2:

Pros:

Cons:

Option 3: Pros:

Cons:

Decision: None of the three.

Instead, grab only the one single game that was played with the extraneous player, and do not add them to the auto-update queue. This will require the SQL table to take on some sort of "update" boolean. This shouldn't be too hard to implement.

This will keep the database lean (ish), while also giving maximum value to players who actually use the site. Bingo. PHP: if ($row['update']) { update(); } else { noooooooo(); }

rosshamish commented 11 years ago

Just make a separate table, "update", and on form submit, add the summonerName to the table. Get auto.php files to look in the "update" table instead of getting distinct summonerName s from "games"