search

rosswarren / epevermodbus

Python library for communicating with EPever solar charge controllers
MIT License
43 stars 18 forks source link

add json outpuy #24

Closed sante85 closed 4 months ago

sante85 commented 11 months ago

@rosswarren can evaluate?

sante85 commented 11 months ago

pr updated

SmithChart commented 11 months ago

@sante85 Thx! LGTM

sante85 commented 11 months ago

when you publish on pypi.org?

thanks

Il giorno dom 24 dic 2023 alle ore 13:42 SmithChart < @.***> ha scritto:

@sante85 https://github.com/sante85 Thx! LGTM

— Reply to this email directly, view it on GitHub https://github.com/rosswarren/epevermodbus/pull/24#issuecomment-1868508124, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADLHTN6TIKIYB5T4Z2KMHZTYLAPJRAVCNFSM6AAAAABA6VHHNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYGUYDQMJSGQ . You are receiving this because you were mentioned.Message ID: @.***>

sante85 commented 11 months ago

hi Rosswarren/Epevermodbus, when you think to publish?

thanks

Il giorno dom 24 dic 2023 alle ore 17:03 Sante Stanisci @.***> ha scritto:

when you publish on pypi.org?

thanks

Il giorno dom 24 dic 2023 alle ore 13:42 SmithChart < @.***> ha scritto:

@sante85 https://github.com/sante85 Thx! LGTM

— Reply to this email directly, view it on GitHub https://github.com/rosswarren/epevermodbus/pull/24#issuecomment-1868508124, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADLHTN6TIKIYB5T4Z2KMHZTYLAPJRAVCNFSM6AAAAABA6VHHNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYGUYDQMJSGQ . You are receiving this because you were mentioned.Message ID: @.***>

sante85 commented 11 months ago

@SmithChart @rosswarren @hrford you are here to merge PR? thanks

SmithChart commented 10 months ago

@sante85 Sorry, I am just a contributor and can not merge.

sante85 commented 10 months ago

Why the owner not merge?

Il ven 5 gen 2024, 19:20 SmithChart @.***> ha scritto:

@sante85 https://github.com/sante85 Sorry, I am just a contributor and can not merge.

— Reply to this email directly, view it on GitHub https://github.com/rosswarren/epevermodbus/pull/24#issuecomment-1879085131, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADLHTN6MVH3LF2OCFR3WWWTYNA75TAVCNFSM6AAAAABA6VHHNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZZGA4DKMJTGE . You are receiving this because you were mentioned.Message ID: @.***>

sante85 commented 10 months ago

i have update, @rosswarren @rafael2k @hrford please merge

rosswarren commented 4 months ago

thank you, these changes have been incorporated into https://github.com/rosswarren/epevermodbus/pull/26 so closing this PR