search

roubachof / Sharpnado.CollectionView

A performant list view supporting: grid, horizontal and vertical layout, drag and drop, and reveal animations.
The Unlicense
244 stars 30 forks source link

Another iOS memory leak #113

Closed AdamEssenmacher closed 7 months ago

AdamEssenmacher commented 7 months ago

PR #112 fixed an iOS memory leak that would manifest itself if even an empty CollectionView was added to a view. Unfortunately, this wasn't the only leak on the iOS side.

This PR also addresses #56 . Once items are added to a CollectionView, a separate leak occurs. This leak can be avoided by rearranging the order in which platform objects are disposed in CleanUp().

@roubachof I think there might be one or two more leaks on the iOS side. If so, expect another PR or two in the next few days.

roubachof commented 7 months ago

NP will wait some days for next release. Keep them coming 😀

AdamEssenmacher commented 7 months ago

@roubachof you're good to pull it in. I think we're good.