Broken - TWW prepatch - Githubissues

(Needs updating to be TWW compatible - issue opened on curse client as well):

1x ...ns/GarrisonMissionManager/GarrisonMissionManager.lua:396: Usage: hooksecurefunc([table,] "function", hookfunc) string "=[C]": in function `hooksecurefunc' [string "@GarrisonMissionManager/GarrisonMissionManager.lua"]:396: in main chunk

string "=[C]": in function `LoadAddOn' [string "@ChampionCommander/cache.lua"]:731: in function <ChampionCommander/cache.lua:730>

[string "@AspectOfTheHunter/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:66: in function <...AspectOfTheHunter/Libs/AceAddon-3.0/AceAddon-3.0.lua:61> [string "@AspectOfTheHunter/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:494: in function `InitializeAddon' [string "@AspectOfTheHunter/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:619: in function <...AspectOfTheHunter/Libs/AceAddon-3.0/AceAddon-3.0.lua:611>

string "=[C]": in function LoadAddOn' [string "@Blizzard_UIParent/Mainline/UIParent.lua"]:422: in functionUIParentLoadAddOn' [string "@Blizzard_UIParent/Mainline/UIParent.lua"]:619: in function `Garrison_LoadUI' [string "@Blizzard_GarrisonBase/GarrisonBaseUtils.lua"]:378: in function <...eBlizzard_GarrisonBase/GarrisonBaseUtils.lua:364>

string "=[C]": in function ShowGarrisonLandingPage' [string "@MasterPlan/PlanA/PlanA.lua"]:109: in functionfunc' [string "@Blizzard_SharedXML/Mainline/UIDropDownMenu.lua"]:1034: in function `UIDropDownMenuButton_OnClick'

Locals: (*temporary) =

{ ERR_OUT_OF_CHI = "Not enough chi" DH_HAVOC_CORE_ABILITY_2 = "Strong melee attack that consumes Fury. If it critical strikes, some Fury is refunded." MultiCastActionButton6Cooldown = MultiCastActionButton6Cooldown { } MerchantItem9ItemButtonStock = MerchantItem9ItemButtonStock { } UNIT_NAMES_COMBATLOG_TOOLTIP = "Color unit names." TrinketMenu_Menu8HotKey = TrinketMenu_Menu8HotKey { } HUD_EDIT_MODE_SETTING_ACTION_BAR_HIDE_BAR_ART = "Hide Bar Art" LE_GAME_ERR_CHAT_RAID_RESTRICTED_TRIAL = 783 HandyNotesPin61 = HandyNotesPin61 { } SPELL_FAILED_CUSTOM_ERROR_71 = "This partygoer wants to dance with you." LE_GAME_ERR_PET_SPELL_TARGETS_DEAD = 421 ERROR_CLUB_TICKET_COUNT_AT_MAX_COMMUNITY = "Can't create any more invite links for this community." RecruitAFriendFrame = RecruitAFriendFrame { } DecursiveSkipListFrameClose = DecursiveSkipListFrameClose { } TutorialFrameLeft19 = TutorialFrameLeft19 { } MultiCastActionButton2Cooldown = MultiCastActionButton2Cooldown { } ERR_TRADE_EQUIPPED_BAG = "You can't trade equipped bags." PVP_RANK_6_1 = "Corporal" MultiBarLeftButton7 = MultiBarLeftButton7 { } OPTION_TOOLTIP_SHOW_MULTIBAR4 = "Attached to the left side of Right Action Bar 1 by default" SkilletRankFrameGray = SkilletRankFrameGray { } LE_GAME_ERR_INVALID_FOLLOW_PVP_COMBAT = 375 MerchantItem3AltCurrencyFrameItem1Text = MerchantItem3AltCurrencyFrameItem1Text { } PROFESSIONS_COLUMN_REAGENTS_NONE = "None" OPTION_SHOW_ACTION_BAR5_TOOLTIP = "Attached to the left side of Action Bar 4 by default" BINDING_NAME_NAMEPLATES = "Show Enemy Nameplates" INSTANCE_UNAVAILABLE_OTHER_TEMPORARILY_DISABLED = "%s cannot enter. This instance is temporarily disabled." COVENANT_MISSIONS_HEALTH = "Health" MAIL_LETTER_TOOLTIP = "Click to make a permanent copy of this letter." PVPReadyDialogBottomArt = PVPReadyDialogBottomArt { } MultiBar6Button4Flash = MultiBar6Button4Flash { } ERR_NOAMMO_S = "%s" CHAT_CONFIG_OTHER_COMBAT =

{ } RematchGameTooltipTexture13 = RematchGameTooltipTexture13 { } ClassNameplateBarPaladinFrameRune5 = ClassNameplateBarPaladinFrameRune5 { } TutorialFrameRight19 = TutorialFrameRight19 { } BOOST2_WARRIOR_COLOSSUSSMASH = "Use |cFFFFFFFFColossus Smash|r.

|cFFFFFFFFColossus Smash|r increases your damage." BN_UNABLE_TO_RESOLVE_NAME = "Unable to whisper '%s'. Blizzard services may be unavailable." CinematicFrameRaidBossEmoteFrame = CinematicFrameRaidBossEmoteFrame { } LE_GAME_ERR_ONLY_ONE_QUIVER = 36 INT_SPELL_DURATION_HOURS = "%d |4hour:hrs;" SLASH_LibQTip1 = "/qtip" LOSS_OF_CONTROL_DISPLAY_FEAR = "Feared" SkilletRequiredListButton1Count = SkilletRequiredListButton1Count { } POWERBAR_PREDICTION_COLOR_MAELSTROM_CODE = "|cff003366" DetailsBreakdownWindowTabFrameSummary8223PhaseScrollContainerPhaseScrollPhaseBarButton4 = DetailsBreakdownWindowTabFrameSummary8223PhaseScrollContainerPhaseScrollPhaseBarButton4 { } BankFrameItem17SearchOverlay = BankFrameItem17SearchOverlay { } AUCTIONATOR_L_DEFAULT_LIST_HEADER = "Default Shopping List" DMG_LCD = "DMG" ACTION_SPELL_MISSED_POSSESSIVE = "1" SLASH_STOPATTACK1 = "/stopattack" MAP_LEGEND_RARE_TOOLTIP = "A special creature that provides various rewards" MultiCastActionButton4HotKey = MultiCastActionButton4HotKey { } MINIMAP_TRACKING_TRAINER_CLASS = "Class Trainer" SLASH_DISMOUNT2 = "/dismount" DUNGEON_FLOOR_DRAGONBLIGHTCHROMIESCENARIO2 = "Andorhal" L =

{ } EMOTE69_CMD1 = "/nosepick" WL_DESC_LOCATION = "Show/hide your location in a movable tooltip." WowTokenRedemptionFrameBg = WowTokenRedemptionFrameBg { } ITEM_REQ_PURCHASE_GUILD_LEVEL = "Requires guild level %d" AutoFollowStatus = AutoFollowStatus { } ARENA_CASUAL = "Skirmish" STABLE_PET_ABILITIES_LIST_HEADER = "Special Abilities" SendStationeryBackgroundRight = SendStationeryBackgroundRight { } MultiBarLeftButton11Name = MultiBarLeftButton11Name { } KEY_ABBR_PADLSTICK = "|A:Gamepad_Gen_LStickIn_32:14:14|a" CONQUEST_BAR = "Conquest %d / %d" MultiBarLeftButton9Border = MultiBarLeftButton9Border { } POSTMASTER_PIPE_KALIMDOR

Wraithlord2015 commented 3 months ago

1x GarrisonMissionManager/MissionUI_Shipyard.lua:155: hooksecurefunc(): GossipFrameOptionsUpdate is not a function string "=[C]": in function `hooksecurefunc' [string "@GarrisonMissionManager/MissionUI_Shipyard.lua"]:155: in main chunk

string "=[C]": in function `LoadAddOn' [string "@ChampionCommander/cache.lua"]:731: in function <ChampionCommander/cache.lua:730>

Locals:

Wraithlord2015 commented 3 months ago

3x ...eGarrisonMissionManager/MissionUI_Shared.lua:322: attempt to index field 'listScroll' (a nil value) [string "@GarrisonMissionManager/MissionUI_Shared.lua"]:322: in function MissionList_ButtonsInit' [string "@GarrisonMissionManager/MissionUI_Garrison.lua"]:210: in functionGarrisonInitUI' [string "@GarrisonMissionManager/MissionUI_Garrison.lua"]:223: in main chunk

string "=[C]": in function `LoadAddOn' [string "@ChampionCommander/cache.lua"]:731: in function <ChampionCommander/cache.lua:730>

Locals: follower_type = 1 opt =

{ gmm_prefix = "" MissionList = GarrisonMissionFrameMissions { } follower_type = 1 gmm_button_mission_page_prefix = "MissionPage" currency = 824 base_frame = GarrisonMissionFrame { } MissionPage = Button { } gmm_button_mission_list_prefix = "MissionList" MissionTab = Frame { } ilevel_max = 675 } blizzard_mission_list = GarrisonMissionFrameMissions { BaseFrameBottomLeft = Texture { } BaseFrameBackground = Texture { } showInProgress = false newMissionIDs =

{ } availableMissions =

{ } inProgressMissions =

{ } CompleteDialog = Frame { } ScrollBox = Frame { } MaterialFrame = Frame { } Tab1 = GarrisonMissionFrameMissionsTab1 { } EmptyListString = FontString { } BaseFrameRight = Texture { } ScrollBar = Frame { } Tab2 = GarrisonMissionFrameMissionsTab2 { } BaseFrameBottomRight = Texture { } BaseFrameBottom = Texture { } BaseFrameTop = Texture { } BaseFrameTopLeft = Texture { } BaseFrameLeft = Texture { } BaseFrameTopRight = Texture { } } frame_prefix = "MissionList" level_anchor = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = "attempt to index field 'listScroll' (a nil value)" gmm_follower_options =

{ 1 =

{ } } gmm_buttons =

{ MissionPage2 = Button { } MissionPageUnavailable1 = Button { } MissionPage3 = Button { } MissionPageYield1 = Button { } MissionPageYield2 = Button { } MissionPage1 = Button { } MissionPageUnavailable2 = Button { } MissionPageUnavailable3 = Button { } MissionPageYield3 = Button { } } gmm_frames =

{ MissionPageFollowerXPGainBase1 = Texture { } MissionPageFollowerWarning1 = FontString { } MissionPageFollowerWarning2 = FontString { } MissionPageFollowerXP3 = Texture { } MissionPageFollowerXPGainBase2 = Texture { } MissionPageFollowerXPGainBonus1 = Texture { } MissionPageFollowerXP2 = Texture { } MissionPageFollowerXPGainBonus3 = Texture { } MissionPageFollowerXPGainBase3 = Texture { } MissionPageFollowerXPGainBonus2 = Texture { } MissionPageFollowerWarning3 = FontString { } MissionPageFollowerXP1 = Texture { } }

jalati commented 3 months ago

@rowaasr13 I've a bugfix/feature branch with some fixes for this that I've tested locally, I do not currently have permission to create a new branch and I'd rather not fork unless you're not interested in supporting this any longer.

Wraithlord2015 commented 3 months ago

Contacted rowaasr13 and was advised that it would be looked into in after launch. All I can advise is to sit tight for now.

jalati commented 3 months ago

Ok. It's working locally for me, I'll look forward to a future official fix, then.

kamillou commented 3 months ago

I can't wait to get a fix. without this addon it's a bit complicated ^^

Wraithlord2015 commented 3 months ago

@jalati is there a way to contact you?

jalati commented 3 months ago

You're doing it right now!

Wraithlord2015 commented 3 months ago

I was going to email or such.. possible to get a share somewhere of what you fixed? For the life of me I can't figure it out. I fix one thing and break about 20 others. LOL

jalati commented 3 months ago

Here's a quick fork I made:

https://github.com/jalati/garrison-mission-manager/tree/bugfix/11.0.2

You can essentially copy everything over your existing install, I'd recommending backing up your current just in case. There is still one error I see periodically, Garrisons, Order Halls and BFA missions appear to work fine.

kamillou commented 3 months ago

ty for quick fork without him I am lost :(

rowaasr13 / garrison-mission-manager

Broken - TWW prepatch #7