search

rowanj / gitx

Fork of Pieter's nice git GUI for OS X. Includes branch/tag sidebar and various fixes. Current development focus is on removing legacy git command line usage in favour of libgit2 and objective-git.
http://rowanj.github.com/gitx
Other
2.15k stars 204 forks source link

Closing a repository document leaks everything #439

Open mattlilek opened 9 years ago

mattlilek commented 9 years ago

Closing a repository's window doesn't return any memory to the system. It looks like there's retain cycles everywhere.

This branch doesn't yet eliminate all leaks but fixes some big ones.

tiennou commented 9 years ago

Side note, make sure that you're not weak-ing things that can't be weak — we have been bit by NSViewController not being allowed to be weak on 10.8 in think.

5sw commented 9 years ago

I already fixed all those leaks and cycles about two years ago: https://github.com/rowanj/gitx/pull/224