re-enable volume shimmin - Githubissues

rpeltekov / ge3t_shim_tool

Conformal Shimming for GE3T using ExSI and OpenSourceImaging Shim Drivers

MIT License

1 stars 1 forks source link

re-enable volume shimmin #28

Closed rpeltekov closed 2 months ago

rpeltekov commented 3 months ago

[ ] volumewise shim: should have a button that does volumewise rather than just slicewise shim computation. essentially it does not make that much sense for the shimming to be just slice by slice for now i think
[x] also make the background of the shim tab show the normal magnitude image.... actually do we want to do this??? actually maybe we do actually want to do this... Actually this will be handled in #34

button is made, just need to finish delivering the feature and testing it

rpeltekov commented 2 months ago

for enabling volume shim work:

[x] clean up the slider enable disable. nvrm it is always enabled b/c you want to be able to select a slice to view within the ROI...
[x] make sure the ROI when nothing is selected yet defaults to the whole volume in the FOV
[x] adjust all the calculations and where solutions
[x] adjust the settings of the solution strings to be dependent on mode and gui to show the solutions differently when it is in volume mode.

rpeltekov commented 2 months ago

to adjust how the calculations get formed for the volume and not conflict / have to overwrite and keep track of the data structures that hold solutions and their string formats here and here,

I will instead hold two different solutions:

for the standard per-slice shim
for the volume shim defined by the ROI and the intersecting portions of the FOV that have signal

Then the buttons/functions to switch the mode will simply adjust the values they look at to apply / visualize the correct solution.

rpeltekov commented 2 months ago

so it is implemented but it looks like it is getting shit results when you use the volume shimming on the whole phantom...

rpeltekov commented 2 months ago

rpeltekov commented 2 months ago

actually there are a lot of bug fixes that still needed to go in...

rpeltekov commented 2 months ago

looks like it somewhat works now. this is after i "overwrote background" like a couple of times...